Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

never use Uint8ClampedArray with texSubImage2D #8199

Merged
merged 1 commit into from
Apr 25, 2019
Merged

never use Uint8ClampedArray with texSubImage2D #8199

merged 1 commit into from
Apr 25, 2019

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Apr 25, 2019

fix #8190

Chrome doesn't support using Uint8ClampedArray with texSubImage2D. Work around that.

I'm not sure how to test this given that it is a environment specific bug. Any ideas?

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page

@ansis
never use Uint8ClampedArray with texSubImage2D
aa85ae3 
fix #8190

Chrome doesn't support using Uint8ClampedArray with texSubImage2D.
Work around that.
@ansis ansis requested a review from mourner April 25, 2019 19:56
mourner
mourner approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're fine without a test for this — the change is simple and clear, and I don't have ideas on how to capture the change too.

@ansis ansis merged commit 0ff9d6e into master Apr 25, 2019
@mourner mourner deleted the fix-8190 branch April 26, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map.updateImage does not work: image should be repainted
2 participants
@ansis @mourner